Re: [PATCH v3 0/4] ci: detect more warnings via `-Og`

From: Jeff King <peff@peff.net>
Date: Jun 8, 2024, 09:28 UTC
Message-ID: <20240608092855.GE2390433@coredump.intra.peff.net>
In-Reply-To: <xmqqwmn0eazm.fsf@gitster.g>

On Fri, Jun 07, 2024 at 01:47:25PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> I am not sure how annoying people will find the V=1 output.  It is
> irrelevant that it is in a collapsible section.  What matters is if
> it helps those who *need* to expand that collapsible section to take
> a look, or if it clutteres what they have to wade through.
> 
> When studying a build failure, I rarely found the exact command line
> given by V=1 helpful, but YMMV---while I am not 100% convinced, let's
> take the series as-is, because not losing information may sometimes
> help even when we need to visually filter out extra clutter.

I had the same thought. I have used V=1 for debugging, but usually debugging Makefile changes locally (i.e., why is my option not being passed correctly). I don't think I've ever wanted it for a CI run.

And I do think people see the output. It may be in a collapsible section on the site, but:

  - you'd uncollapse that section if there is a build failure, and now
    your error messages are that much harder to find

  - if you look at the output outside of the site, you'll see the
    uncollapsed sections. And I usually view them in a local pager using
    curl[1].

I guess I won't know until I see it in action, but I have a pretty strong suspicion that it will be annoying.

-Peff

[1] For the curious, I use the script below to grab the logs from the
    last failed workflow run. It's pretty old, and I won't be surprised
    if there's a less ugly way to do it with the "gh" CLI tool or
    similar these days.

-- >8 -- repo=peff/git GITHUB_TOKEN=...your.pat.here...

actions() {
  curl -sL \
    -H 'Accept: application/vnd.github.v3+json' \
    -H "Authorization: token $GITHUB_TOKEN" \
    "https://api.github.com/repos/$repo/actions/$1"
}

run=$(
  actions runs?status=failure |
  jq -r '.workflow_runs | .[] | .id' |
  head -1
)

actions runs/$run/jobs?per_page=100 |
jq -r '.jobs | .[] | select(.conclusion == "failure") | "\(.id) \(.name)"' |
while read id name; do
  {
    echo "==> $name"
    actions jobs/$id/logs
  } | less '+/not.ok|##\[error\]'
done