From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 10 Jun 2024 07:01:06 GMT
Subject: Re: [PATCH v3 2/4] Makefile: add ability to append to CFLAGS and LDFLAGS
Message-ID: <ZmaksqGEpLcMCjrn@tanuki>
In-Reply-To: <xmqq4ja3cl87.fsf@gitster.g>

On Sat, Jun 08, 2024 at 12:01:28PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
> 
> > Another way to do this is just:
> >
> > diff --git a/Makefile b/Makefile
> > index 2f5f16847a..9cd3b252ff 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1446,8 +1446,8 @@ ALL_COMMANDS_TO_INSTALL += git-upload-archive$(X)
> >  ALL_COMMANDS_TO_INSTALL += git-upload-pack$(X)
> >  endif
> >  
> > -ALL_CFLAGS = $(DEVELOPER_CFLAGS) $(CPPFLAGS) $(CFLAGS)
> > -ALL_LDFLAGS = $(LDFLAGS)
> > +ALL_CFLAGS = $(DEVELOPER_CFLAGS) $(CPPFLAGS) $(CFLAGS) $(CFLAGS_APPEND)
> > +ALL_LDFLAGS = $(LDFLAGS) $(LDFLAGS_APPEND)
> 
> Much nicer.

Agreed, this is much nicer. Will adapt, thanks!

Patrick