Re: [PATCH v2 2/2] ci: compile "linux-gcc-default" job with -Og
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 7, 2024, 18:45 UTC
- Message-ID
- <xmqqikykd22p.fsf@gitster.g>
- In-Reply-To
- <ZmKalkqR3GqCXfqz@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
> We're unlikely to break existing workflows though if we name this > variable something like `OPTIMIZATION_LEVEL`.
Yeah, being more explicit is always good.
Show 5 quoted lines
> We could also generalize this a bit and introduce `CFLAGS_APPEND` > instead. Optimization levels are last-one-wins anyway, so people can use > that to append their own flags without overriding existing values. It > would also mean that we can avoid repeating the CFLAGS that we already > have in our Makefile in our CI scripts.
Yup, Peff's $(O) cannot serve as such, but my $(O) is already being used as such. Naming the variable that gives additional CFLAGS as such is probably a good way to go.
Thanks.