Re: [PATCH 1/2] ci: fix check for Ubuntu 20.04

From: Jeff King <peff@peff.net>
Date: Jun 6, 2024, 06:53 UTC
Message-ID: <20240606065328.GB646308@coredump.intra.peff.net>
In-Reply-To: <f91004a4382c95b1b87bf3d1aafc018af2b7b92e.1717655210.git.ps@pks.im>

On Thu, Jun 06, 2024 at 08:30:25AM +0200, Patrick Steinhardt wrote:

Show 8 quoted lines

> In 5ca0c455f1 (ci: fix Python dependency on Ubuntu 24.04, 2024-05-06),
> we made the use of Python 2 conditional on whether or not the CI job
> runs Ubuntu 20.04. There was a brown-paper-bag-style bug though, where
> the condition forgot to invoke the `test` builtin. The result of it is
> that the check always fails, and thus all of our jobs run with Python 3
> by accident.
> 
> Fix this.

Yikes. This looks obviously correct. Though I guess nobody noticed or cared that we were not using python 2? It sounds like it is a nice-to-have to get more coverage, but the platform in question is happy to use python 3).

-Peff