Re: [PATCH v4 2/2] ci: compile "linux-gcc-default" job with -Og

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2024, 15:47 UTC
Message-ID: <xmqqr0d0n8tn.fsf@gitster.g>
In-Reply-To: <20240613101522.GC817573@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 18 quoted lines

> I think you could do it with:
>
> 			if (data)
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wuninitialized"
> 				munmap(data, mtimes_size);
> #pragma GCC diagnostic pop
>
> which is...ugly. There's a _Pragma() operator, too, which I think would
> let you make a macro like:
>
> 			if (data)
> 				SUPPRESS("-Wuninitialized", munmap(data, mtimes_size));
>
> which is maybe slightly less horrific? Still pretty magical though.
>
> But if the alternative is to do none of that, and just continue to avoid
> looking for warnings with -Os, I prefer that.

Oh, we are in agreement. Such effort to annotate code and tolerate inconvenience is better spent elsewhere but expertise and competence are not as fungible as I wish them to be ;-)

Thanks.