Re: BUG: Value for GIT_SSL_NO_VERIFY has no effect

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sep 15, 2022, 16:15 UTC
Message-ID: <YyNPp3UMCii67ugC@tapette.crustytoothpaste.net>
In-Reply-To: <xmqq8rmkpsit.fsf@gitster.g>

On 2022-09-15 at 15:27:22, Junio C Hamano wrote:

Show 5 quoted lines

> I did a quick audit of the environment variables documented in
> git(1) and it is a bit messy.  Many environment variables use
> git_env_bool() to make themselves a proper Boolean environment
> variable, but some others that are described to take "1" to "enable"
> do not honor the usual "yes/true/on" convention.

Yeah. I think we could well adjust this to accept "0" or "false" to turn it off if we liked, but it doesn't right now. I think that could well be valuable if we wanted to make a change in the future.

I could submit a patch to do this over the next couple of days for this variable and GIT_CURL_VERBOSE as well if we decide we want to do so.

> SSL_NO_VERIFY is worse, as it is not even described.  So we should
> add it to "git help git".

It is documented in git-config(1), but of course we should also document in git(1) as suggested. Do you want to turn this into a nice patch or would you prefer that I turned it into one with your sign-off?

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA