[PATCH 3/5] environ: GIT_FLUSH should be made a usual Boolean
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2022, 16:06 UTC
- Message-ID
- <20220915160659.126441-4-gitster@pobox.com>
- In-Reply-To
- <20220915160659.126441-1-gitster@pobox.com>
This uses atoi() and checks if the result is not zero to decide what to do. Turning it into the usual Boolean environment variable to use git_env_bool() would not break those who have been using "set to 0, or set to non-zero, that can be parsed with atoi()" values, but will match the expectation of those who expected "true" to mean "yes".
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- Documentation/git.txt | 1 + write-or-die.c | 1 + 2 files changed, 2 insertions(+)
diff --git a/Documentation/git.txt b/Documentation/git.txt index e2f61a1ec8..3d31252bf2 100644 --- a/Documentation/git.txt +++ b/Documentation/git.txt @@ -722,6 +722,7 @@ for further details. waiting for someone with sufficient permissions to fix it. `GIT_FLUSH`:: +// NEEDSWORK: make it into a usual Boolean environment variable If this environment variable is set to "1", then commands such as 'git blame' (in incremental mode), 'git rev-list', 'git log', 'git check-attr' and 'git check-ignore' will diff --git a/write-or-die.c b/write-or-die.c index c4fd91b5b4..aaa0318e82 100644 --- a/write-or-die.c +++ b/write-or-die.c @@ -23,6 +23,7 @@ void maybe_flush_or_die(FILE *f, const char *desc) if (f == stdout) { if (skip_stdout_flush < 0) { + /* NEEDSWORK: make this a normal Boolean */ cp = getenv("GIT_FLUSH"); if (cp) skip_stdout_flush = (atoi(cp) == 0);
-- 2.37.3-780-gd940517dcb