Re: [PATCH 3/5] environ: GIT_FLUSH should be made a usual Boolean

From: René Scharfe <l.s.r@web.de>
Date: Jan 4, 2023, 16:36 UTC
Message-ID: <7ccf9109-1566-a2b9-5ca8-067ebf49706d@web.de>
In-Reply-To: <xmqqwn62u7nh.fsf@gitster.g>

Am 04.01.23 um 07:37 schrieb Junio C Hamano:

Show 6 quoted lines

> René Scharfe <l.s.r@web.de> writes:
>
>> GIT_FLUSH=10000000000  yes                     if stdin is not a file
>
> Is this because the int is so large that git_parse_signed() notices
> that it is out of bound (hence "bogus")?

Yes, atoi() overflows silently and git_parse_maybe_bool() returns -1.

René

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.