BUG: Value for GIT_SSL_NO_VERIFY has no effect

Hi,

It appears that any value assigned to GIT_SSL_NO_VERIFY (true or false) has no effect on the GIT operations. For testing purposes, we have created a host entry for github.com and mapped it to foo.com.

Step 1: Clone the repo with default configuration.

git clone https://foo.com/bridgepate/gs_auto_provision.git Cloning into 'gs_auto_provision'... fatal: unable to access 'https://foo.com/bridgepate/gs_auto_provision.git/': SSL: certificate subject name (github.com) does not match target host name 'foo.com'

As expected, the above fails with SSL certificate error.

Step 2:  Clone with GIT_SSL_NO_VERIFY set to true

GIT_SSL_NO_VERIFY=true git clone https://foo.com/bridgepate/gs_auto_provision.git Cloning into 'gs_auto_provision'... warning: redirecting to https://github.com/bridgepate/gs_auto_provision.git/ remote: Enumerating objects: 244, done. remote: Counting objects: 100% (3/3), done. remote: Compressing objects: 100% (3/3), done. remote: Total 244 (delta 0), reused 1 (delta 0), pack-reused 241 Receiving objects: 100% (244/244), 108.75 KiB | 611.00 KiB/s, done. Resolving deltas: 100% (131/131), done.

The above works as expected.

Step 3:  Clone with GIT_SSL_NO_VERIFY to false

GIT_SSL_NO_VERIFY=false git clone https://foo.com/bridgepate/gs_auto_provision.git Cloning into 'gs_auto_provision'... warning: redirecting to https://github.com/bridgepate/gs_auto_provision.git/ remote: Enumerating objects: 244, done. remote: Counting objects: 100% (3/3), done. remote: Compressing objects: 100% (3/3), done. remote: Total 244 (delta 0), reused 1 (delta 0), pack-reused 241 Receiving objects: 100% (244/244), 108.75 KiB | 1.38 MiB/s, done. Resolving deltas: 100% (131/131), done.

We expect the above to fail as we saw in step 1, but it succeeded. This shows that the value for this environment variable is ignored.

Following is the platform details

OS: Ubuntu 22.04.1 LTS
GIT: git version 2.34.1

Thanks in advance

Brijesh Patel