Re: [PATCH 3/5] environ: GIT_FLUSH should be made a usual Boolean

From: Jeff King <peff@peff.net>
Date: Jan 6, 2023, 09:10 UTC
Message-ID: <Y7flkC6BXdvYJxve@coredump.intra.peff.net>
In-Reply-To: <07b8e696-2736-142e-1937-7e60636de5f4@web.de>

On Wed, Jan 04, 2023 at 05:36:11PM +0100, René Scharfe wrote:

> But this leaves the possibility that someone sets GIT_FLUSH=absolutely,
> loses data due to lack of flushing and is dissatisfied with the lack of
> parse errors.

I'd worry much more about GIT_FLUSH=ture.

As you noted, we are not currently diagnosing problems here, so your patch is certainly not making anything worse. But maybe it's an opportunity for us to improve things. ;)

-Peff