Re: [PATCH v2 09/17] reachable: add options to add_unseen_recent_objects_to_traversal

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 2, 2022, 21:28 UTC
Message-ID: <Yh/hctKsg1gzmo3o@nand.local>
In-Reply-To: <245e34c3-ba85-2bb3-d17a-e48ee5b142bd@github.com>

On Wed, Mar 02, 2022 at 03:19:57PM -0500, Derrick Stolee wrote:

Show 7 quoted lines

> Nit: just realized this include could be replaced by a struct
> declaration:
>
> >  struct progress;
> >  struct rev_info;
>
> Like these. 'struct object;' should be enough for the typedef.

Good catch. We would need one for the packed_git struct, too. I don't have a strong opinion about including object.h or not, though needing two stubs pushes me slightly in the direction of leaving the include alone.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.