From: Taylor Blau Date: Wed, 02 Mar 2022 21:28:18 GMT Subject: Re: [PATCH v2 09/17] reachable: add options to add_unseen_recent_objects_to_traversal Message-ID: In-Reply-To: <245e34c3-ba85-2bb3-d17a-e48ee5b142bd@github.com> On Wed, Mar 02, 2022 at 03:19:57PM -0500, Derrick Stolee wrote: > Nit: just realized this include could be replaced by a struct > declaration: > > > struct progress; > > struct rev_info; > > Like these. 'struct object;' should be enough for the typedef. Good catch. We would need one for the packed_git struct, too. I don't have a strong opinion about including object.h or not, though needing two stubs pushes me slightly in the direction of leaving the include alone. Thanks, Taylor