Re: [PATCH v4 02/17] pack-mtimes: support reading .mtimes files

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 19, 2022, 10:40 UTC
Message-ID: <220519.86zgjd4wvk.gmgdl@evledraar.gmail.com>
In-Reply-To: <8f9fd21be9fcdda5c73d800fc66d1087d61a6888.1652915424.git.me@ttaylorr.com>

On Wed, May 18 2022, Taylor Blau wrote:

Nit:

Show 5 quoted lines

> +  - A 4-byte magic number '0x4d544d45' ('MTME').
> +
> +  - A 4-byte version identifier (= 1).
> +
> +  - A 4-byte hash function identifier (= 1 for SHA-1, 2 for SHA-256).

Here we let it suffice that later we'll say "All 4-byte numbers are in network order".

> +  - A table of 4-byte unsigned integers in network order. The ith

But here we call out "network order" explicitly, shouldn't this just be s/ in network order//?

Show 9 quoted lines

> +    value is the modification time (mtime) of the ith object in the
> +    corresponding pack by lexicographic (index) order. The mtimes
> +    count standard epoch seconds.
> +
> +  - A trailer, containing a checksum of the corresponding packfile,
> +    and a checksum of all of the above (each having length according
> +    to the specified hash function).
> +
> +All 4-byte numbers are in network order.

I.e. this is sufficient.