RE: [PATCH v5 02/17] pack-mtimes: support reading .mtimes files

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: May 24, 2022, 23:24 UTC
Message-ID: <016e01d86fc5$64ecf180$2ec6d480$@nexbridge.com>
In-Reply-To: <Yo1bUbys+Fz7g+6h@nand.local>

On May 24, 2022 6:25 PM ,Taylor Blau write:

Show 9 quoted lines

>On Tue, May 24, 2022 at 03:44:00PM -0400, rsbecker@nexbridge.com wrote:
>> I am again concerned about 32-bit time_t assumptions. time_t is 32-bit
>> on some platforms, signed/unsigned, and sometimes 64-bit. We are
>> talking about potentially long-persistent files, as I understand this
>> series, so we should not be limiting times to end at 2038. That's only
>> 16 years off and I would wager that many clones that exist today will exist then.
>
>Note that we're using unsigned fields here, so we have until 2106 (see my earlier
>response on this in https://lore.kernel.org/git/YdiXecK6fAKl8++G@nand.local/).

I appreciate that, but 32-bit time_t is still signed on many platforms, so when cast, it still might, at some point in another series, cause issues. Please be cautious. I expect that this is the particular hill on which I will die. 😉 --Randall