Re: [PATCH v2 09/17] reachable: add options to add_unseen_recent_objects_to_traversal

From: Derrick Stolee <derrickstolee@github.com>
Date: Mar 2, 2022, 20:19 UTC
Message-ID: <245e34c3-ba85-2bb3-d17a-e48ee5b142bd@github.com>
In-Reply-To: <6f0e84273f78797c728058521969e73f8817b49c.1646182671.git.me@ttaylorr.com>

On 3/1/2022 7:58 PM, Taylor Blau wrote:

Show 10 quoted lines

> diff --git a/reachable.h b/reachable.h
> index 5df932ad8f..b776761baa 100644
> --- a/reachable.h
> +++ b/reachable.h
> @@ -1,11 +1,18 @@
>  #ifndef REACHEABLE_H
>  #define REACHEABLE_H
>  
> +#include "object.h"
> +

Nit: just realized this include could be replaced by a struct
declaration:

>  struct progress;
>  struct rev_info;

Like these. 'struct object;' should be enough for the typedef.

Show 9 quoted lines

>  
> +typedef void report_recent_object_fn(const struct object *, struct packed_git *,
> +				     off_t, time_t);
> +
>  int add_unseen_recent_objects_to_traversal(struct rev_info *revs,
> -					   timestamp_t timestamp);
> +					   timestamp_t timestamp,
> +					   report_recent_object_fn cb,
> +					   int ignore_in_core_kept_packs);

Thanks, -Stolee