Re: [PATCH v4 15/17] builtin/repack.c: add cruft packs to MIDX during geometric repack

From: Taylor Blau <me@ttaylorr.com>
Date: May 20, 2022, 22:42 UTC
Message-ID: <YogZPpWAamW1qREE@nand.local>
In-Reply-To: <220519.86r14p4v0q.gmgdl@evledraar.gmail.com>

On Thu, May 19, 2022 at 01:32:26PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> > @@ -161,8 +162,11 @@ static void collect_pack_filenames(struct string_list *fname_nonkept_list,
> >  		if ((extra_keep->nr > 0 && i < extra_keep->nr) ||
> >  		    (file_exists(mkpath("%s/%s.keep", packdir, fname))))
> >  			string_list_append_nodup(fname_kept_list, fname);
> > -		else
> > -			string_list_append_nodup(fname_nonkept_list, fname);
> > +		else {
> > +			struct string_list_item *item = string_list_append_nodup(fname_nonkept_list, fname);
>
> Nit: very long line, and we end up with {} just on the else, not the if.

Thanks for spotting, I split this line up and added braces to the other half of this conditional.

Thanks, Taylor