Re: [PATCH 4/9] pack-write.c: rename `.idx` files after `*.rev`

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 9, 2021, 14:37 UTC
Message-ID: <YTocEy7PZqL6nvuY@nand.local>
In-Reply-To: <87h7eufaw5.fsf@evledraar.gmail.com>

On Thu, Sep 09, 2021 at 09:46:57AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

>
> On Wed, Sep 08 2021, Taylor Blau wrote:
>
> > [...]
> >
> > Signed-off-by: Taylor Blau <me@ttaylorr.com>
> > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> > Signed-off-by: Taylor Blau <me@ttaylorr.com>
>
> git commit --amend --signed-off-by-harder ? :)

I don't think so, though I had to check myself before sending. Documentation/SubmittingPatches says:

    Notice that you can place your own `Signed-off-by` trailer when
    forwarding somebody else's patch with the above rules for
    D-C-O.  Indeed you are encouraged to do so.  Do not forget to
    place an in-body "From: " line at the beginning to properly attribute
    the change to its true author (see (2) above).

Here it's awkward because you modified my original patch and then I sent your modified result out. But I think the s-o-b chain still makes sense: I wrote the original patch, and signed it off. Then you modified it, signing that off. Finally, I sent it to the list, signing off on your modification.

> I.e. the duplicate header entry can go, maybe something Junio will fix
> up while queuing...

If I misread SubmittingPatches then I'm happy to fix it myself, but this was the intended outcome.

Thanks, Taylor