Re: [PATCH 3/3] pack-write: rename *.idx file into place last (really!)

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 7, 2021, 22:31 UTC
Message-ID: <YTfoQJf6M5BCIT1R@nand.local>
In-Reply-To: <patch-3.3-78976fcb7b2-20210907T193600Z-avarab@gmail.com>

On Tue, Sep 07, 2021 at 09:42:38PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> +			/*
> +			 * We must write the *.idx last, so that anything that expects
> +			 * an accompanying *.rev, *.bitmap etc. can count on it being
> +			 * present.
> +			 *
> +			 * See also corresponding logic in the "exts"
> +			 * struct in builtin/repack.c
> +			 */

TBH, I'm not sure the cycle between comments helps much, and it would probably suffice to say:

  /*
   * write the .idx last, so everything else can count on its existence
   */

In both places. But I don't think that it makes much of a difference, really, so either outcome is fine with me.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.