Re: [PATCH 0/9] packfile: avoid .idx rename races
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Sep 9, 2021, 14:40 UTC
- Message-ID
- <YToc+W7q1F8IXYK+@nand.local>
- In-Reply-To
- <874kauf9wq.fsf@evledraar.gmail.com>
On Thu, Sep 09, 2021 at 10:06:24AM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 6 quoted lines
> I think it's probably redundant to note it at this point but I've given > this a thorough review and it all looks good to me. I left some > comments/musings on minor points in the series, but none of those IMO > require a re-roll except perhaps the duplicate Signed-off-by headers, > depending on what Junio thinks & if he's going to fix those while > queuing.
Thanks, and likewise your parts of this series look good to me (obviously, or I wouldn't have sent it otherwise ;)).
The duplicate s-o-b's are intentional, but see my response in 2/9 (I'd link to it, but vger seems to be a little sluggish for me this morning) for why. If I made an error there, I'm happy to fix it up for Junio.
Thanks, Taylor