Re: [PATCH 0/2] pack-write,repack: prevent opening packs too early

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 1, 2021, 05:12 UTC
Message-ID: <YS8LyanAqro3PDlm@nand.local>
In-Reply-To: <YS8IqxNbxy0YrXSe@coredump.intra.peff.net>

On Wed, Sep 01, 2021 at 12:59:23AM -0400, Jeff King wrote:

Show 5 quoted lines

> So anyway. I think we definitely want the index-pack.c change. We
> _could_ stop there and change the read side as a separate series, but I
> think that until we do, the ordering changes on the write side aren't
> really doing that much. They're shrinking the race a little, I guess,
> but it's still very much there.

Yeah, now that I've had a chance to look at it it seems pretty straightforward. Probably limited to checks in prepare_pack(), and add_pack_to_midx(), which are the lone two callbacks of for_each_file_in_pack_dir().

I'll make sure that I'm not missing anything and then send a reroll tomorrow.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.