Re: [PATCH v2 4/4] pack-write: rename *.idx file into place last (really!)

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 8, 2021, 04:24 UTC
Message-ID: <YTg69VUlpJvSNvAm@nand.local>
In-Reply-To: <patch-v2-4.4-70f4a9767d-20210908T003631Z-avarab@gmail.com>

On Wed, Sep 08, 2021 at 02:38:28AM +0200, Ævar Arnfjörð Bjarmason wrote:

> Follow-up a preceding commit (pack-write.c: rename `.idx` file into
> place last, 2021-08-16)[1] and rename the *.idx file in-place after we
> write the *.bitmap. The preceding commit fixed the issue of *.idx
> being written before *.rev files, but did not do so for *.idx files.

s/idx/bitmap/ in the last line, I believe.

Otherwise this patch looks good to me.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.