Re: [PATCH] Do check_repository_format() early

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 28, 2007, 18:11 UTC
Message-ID: <Pine.LNX.4.64.0711281810410.27959@racer.site>
In-Reply-To: <fcaeb9bf0711280924v34160eddsf8a75f8f8cee389c@mail.gmail.com>

Hi,

On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:

Show 9 quoted lines

> The comment is clearly not clear enough. Maybe this?
> 
> +                     if (!work_tree_env) {
> +                             retval = set_work_tree(gitdirenv);
> +                             /* config may override worktree (see
> set_work_tree comment) */
> +                             check_repository_format();
> +                             return retval;
> +                     }

Perfect.  Please make it so, and add my ACK.

Thanks, Dscho