Re: [PATCH] Do check_repository_format() early

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Dec 1, 2007, 06:50 UTC
Message-ID: <fcaeb9bf0711302250ldfb543evd6d5f70d95ae51f7@mail.gmail.com>
In-Reply-To: <7v3aunb0q4.fsf@gitster.siamese.dyndns.org>

On Dec 1, 2007 9:36 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:
> >
> >> The comment is clearly not clear enough. Maybe this?
> >>
> >> +                     if (!work_tree_env) {
> >> +                             retval = set_work_tree(gitdirenv);
> >> +                             /* config may override worktree (see
> >> set_work_tree comment) */
> >> +                             check_repository_format();
> >> +                             return retval;
> >> +                     }
> >
> > Perfect.  Please make it so, and add my ACK.
>
> Looks sensible, but can this be accompanied with a trivial test to
> demonstrate the existing breakage?
>

How can I reliably check setup_git_directory_gently()? I can pick one command that uses setup_git_directory_gently(). But commands change. Once they turn to setup_git_directory(), the test will no longer be valid.

-- 
Duy