From: Johannes Schindelin Date: Wed, 28 Nov 2007 18:11:17 GMT Subject: Re: [PATCH] Do check_repository_format() early Message-ID: In-Reply-To: Hi, On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote: > The comment is clearly not clear enough. Maybe this? > > + if (!work_tree_env) { > + retval = set_work_tree(gitdirenv); > + /* config may override worktree (see > set_work_tree comment) */ > + check_repository_format(); > + return retval; > + } Perfect. Please make it so, and add my ACK. Thanks, Dscho