Re: [PATCH] Do check_repository_format() early

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 28, 2007, 17:05 UTC
Message-ID: <Pine.LNX.4.64.0711281703470.27959@racer.site>
In-Reply-To: <20071128165837.GA5903@laptop>

Hi,

On Wed, 28 Nov 2007, Nguyễn Thái Ngọc Duy wrote:

Show 13 quoted lines

> @@ -246,8 +246,13 @@ const char *setup_git_directory_gently(int *nongit_ok)
>  			static char buffer[1024 + 1];
>  			const char *retval;
>  
> -			if (!work_tree_env)
> -				return set_work_tree(gitdirenv);
> +			if (!work_tree_env) {
> +				retval = set_work_tree(gitdirenv);
> +				/* config may override worktree */
> +				check_repository_format();
> +				return retval;
> +			}
> +			check_repository_format();

Why not move this check before the if?  Other than that, ACK.

Ciao, Dscho