Re: [PATCH] Do check_repository_format() early

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 1, 2007, 02:36 UTC
Message-ID: <7v3aunb0q4.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0711281810410.27959@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 13 quoted lines

> On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:
>
>> The comment is clearly not clear enough. Maybe this?
>> 
>> +                     if (!work_tree_env) {
>> +                             retval = set_work_tree(gitdirenv);
>> +                             /* config may override worktree (see
>> set_work_tree comment) */
>> +                             check_repository_format();
>> +                             return retval;
>> +                     }
>
> Perfect.  Please make it so, and add my ACK.

Looks sensible, but can this be accompanied with a trivial test to demonstrate the existing breakage?