Re: [PATCH 10/11] Introduce git_etc_gitconfig() that encapsulates access of ETC_GITCONFIG.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 13, 2007, 21:43 UTC
Message-ID: <Pine.LNX.4.64.0711132140000.4362@racer.site>
In-Reply-To: <200711132235.13463.johannes.sixt@telecom.at>

Hi,

On Tue, 13 Nov 2007, Johannes Sixt wrote:

Show 21 quoted lines

> On Tuesday 13 November 2007 22:22, Johannes Schindelin wrote:
>
> > On Tue, 13 Nov 2007, Johannes Sixt wrote:
> > > diff --git a/config.c b/config.c
> > > index dc3148d..dd7e9ad 100644
> > > --- a/config.c
> > > +++ b/config.c
> > > @@ -452,6 +452,11 @@ int git_config_from_file(config_fn_t fn, const char
> > > *filename) return ret;
> > >  }
> > >
> > > +const char *git_etc_gitconfig(void)
> > > +{
> > > +	return ETC_GITCONFIG;
> > > +}
> > > +
> >
> > Wouldn't this logically belong into environment.c?
> 
> I don't think so. environment.c is about things that concern the 
> repository. This is really only about configuration.

I thought that environment.c is about getting certain settings from the environment. In that sense, git_etc_gitconfig() would live a happier life there.

But I do not care all that deeply. I know _I_ would have looked for it in environment.c first, but then, there's always good ole' git-grep.

Ciao, Dscho