Re: [PATCH 05/11] Use is_absolute_path() in sha1_file.c.
- From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
- Date
- Nov 14, 2007, 21:57 UTC
- Message-ID
- <200711142257.12962.robin.rosenberg.lists@dewire.com>
- In-Reply-To
- <200711132243.05877.johannes.sixt@telecom.at>
tisdag 13 november 2007 skrev Johannes Sixt:
Show 21 quoted lines
> On Tuesday 13 November 2007 22:39, Johannes Schindelin wrote: > > Hi, > > > > On Tue, 13 Nov 2007, Johannes Sixt wrote: > > > diff --git a/sha1_file.c b/sha1_file.c > > > index f007874..560c0e0 100644 > > > --- a/sha1_file.c > > > +++ b/sha1_file.c > > > @@ -86,7 +86,7 @@ int safe_create_leading_directories(char *path) > > > char *pos = path; > > > struct stat st; > > > > > > - if (*pos == '/') > > > + if (is_absolute_path(path)) > > > pos++; > > > > Is this enough? On Windows, certain "absolute" paths would need "pos += > > 3", no? > > True, but this series is not yet about the MinGW port itself. It will be > changed eventually, but not at this time.
D:/FOO and //deathstar/core work fine in cygwin, which is supported. but git do not work well with such paths in some places.
-- robin