Re: [PATCH 0/11] Miscellaneous MinGW port fallout
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 13, 2007, 22:22 UTC
- Message-ID
- <7v8x51ss3s.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <Pine.LNX.4.64.0711132145400.4362@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 16 quoted lines
> On Tue, 13 Nov 2007, Johannes Sixt wrote: >> On Tuesday 13 November 2007 22:10, Junio C Hamano wrote: >> > Johannes Sixt <johannes.sixt@telecom.at> writes: >> > > On Tuesday 13 November 2007 21:04, Johannes Sixt wrote: >> > > ... and so allow that the compiled binaries are installed in any >> > > directory that the user chooses. >> > >> > If you can do that without breaking the tests (specifically, the >> > test script should pick up the version of git you just built, >> > not from /usr/bin nor /usr/local/stow/git/bin) that would be >> > great. >> >> Sorry, I don't understand your statement. Do you see any tests breaking? > > I guess what Junio is getting at: if your changes could lead to our not > needing to hard code defaults, that would be awesome.
Yes. Another thing I said was that it would be grave regression for testability if the change leads git to look at somewhere else other than it was told to look via GIT_EXEC_PATH environment,