Re: [PATCH 0/11] Miscellaneous MinGW port fallout

From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Nov 13, 2007, 21:32 UTC
Message-ID: <200711132232.11730.johannes.sixt@telecom.at>
In-Reply-To: <7vlk91svgf.fsf@gitster.siamese.dyndns.org>

On Tuesday 13 November 2007 22:10, Junio C Hamano wrote:

Show 17 quoted lines

> Johannes Sixt <johannes.sixt@telecom.at> writes:
> > On Tuesday 13 November 2007 21:04, Johannes Sixt wrote:
> >> [PATCH 09/11] Allow a relative builtin template directory.
> >> [PATCH 10/11] Introduce git_etc_gitconfig() that encapsulates access
> >> 	of ETC_GITCONFIG.
> >> [PATCH 11/11] Allow ETC_GITCONFIG to be a relative path.
> >>
> >> These need probably some discussion. They avoid that $(prefix) is
> >> hardcoded and so allows that an arbitrary installation directory.
> >
> > ... and so allow that the compiled binaries are installed in any
> > directory that the user chooses.
>
> If you can do that without breaking the tests (specifically, the
> test script should pick up the version of git you just built,
> not from /usr/bin nor /usr/local/stow/git/bin) that would be
> great.

Sorry, I don't understand your statement. Do you see any tests breaking?

These changes are only about where git-init looks up the templates and where the system configuration is looked for. They change git's behavior only if config.mak contains relative paths like this:

sysconfdir = ../etc template_dir = ../share/git-core

It has nothing to do with where the test suite looks for the executables.

-- Hannes