Re: [PATCH 05/11] Use is_absolute_path() in sha1_file.c.
- From
Johannes Sixt <johannes.sixt@telecom.at>
- Date
- Nov 13, 2007, 21:43 UTC
- Message-ID
- <200711132243.05877.johannes.sixt@telecom.at>
- In-Reply-To
- <Pine.LNX.4.64.0711132138360.4362@racer.site>
On Tuesday 13 November 2007 22:39, Johannes Schindelin wrote:
Show 17 quoted lines
> Hi, > > On Tue, 13 Nov 2007, Johannes Sixt wrote: > > diff --git a/sha1_file.c b/sha1_file.c > > index f007874..560c0e0 100644 > > --- a/sha1_file.c > > +++ b/sha1_file.c > > @@ -86,7 +86,7 @@ int safe_create_leading_directories(char *path) > > char *pos = path; > > struct stat st; > > > > - if (*pos == '/') > > + if (is_absolute_path(path)) > > pos++; > > Is this enough? On Windows, certain "absolute" paths would need "pos += > 3", no?
True, but this series is not yet about the MinGW port itself. It will be changed eventually, but not at this time.
-- Hannes