Re: [PATCH 10/11] Introduce git_etc_gitconfig() that encapsulates access of ETC_GITCONFIG.
- From
Johannes Sixt <johannes.sixt@telecom.at>
- Date
- Nov 13, 2007, 21:35 UTC
- Message-ID
- <200711132235.13463.johannes.sixt@telecom.at>
- In-Reply-To
- <Pine.LNX.4.64.0711132121440.4362@racer.site>
On Tuesday 13 November 2007 22:22, Johannes Schindelin wrote:
Show 18 quoted lines
> Hi,
>
> On Tue, 13 Nov 2007, Johannes Sixt wrote:
> > diff --git a/config.c b/config.c
> > index dc3148d..dd7e9ad 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -452,6 +452,11 @@ int git_config_from_file(config_fn_t fn, const char
> > *filename) return ret;
> > }
> >
> > +const char *git_etc_gitconfig(void)
> > +{
> > + return ETC_GITCONFIG;
> > +}
> > +
>
> Wouldn't this logically belong into environment.c?I don't think so. environment.c is about things that concern the repository. This is really only about configuration.
-- Hannes