Re: [PATCH] Introduce 'git-format-patch --suffix=patch'

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Jan 17, 2007, 19:51 UTC
Message-ID: <D085A8A2-F1EC-47EC-8D96-B8A06E483BDB@silverinsanity.com>
In-Reply-To: <7vzm8hqws4.fsf@assigned-by-dhcp.cox.net>

On Jan 17, 2007, at 2:27 PM, Junio C Hamano wrote:

Show 10 quoted lines

> Andy Whitcroft <apw@shadowen.org> writes:
>
>>> -	strcpy(filename + len, ".txt");
>>> +	sprintf(filename + len, ".%s", fmt_patch_suffix);
>>
>> This doesn't give us any possibility of not having a suffix.  Can  
>> we not
>> include the . in the suffix here so that we can specify it as "".
>
> I've considered it, but I do not think it is worth it.

I think that the best form of DWIM is that if the suffix is "", then you simply skip the entire sprintf. Then any suffix has to have the '.', but no suffix doesn't have it. Additional DWIMMmery could remove an initial '.' from the suffix so that users expecting it to be there don't get ".." in their file.

Patch (on top of yours) should follow shortly.

~~ Brian