Re: [RFC] Add a suffix option to git-format-patch

From: Horst H. von Brand <vonbrand@inf.utfsm.cl>
Date: Jan 17, 2007, 16:39 UTC
Message-ID: <200701171639.l0HGdNq4021842@laptop13.inf.utfsm.cl>
In-Reply-To: <Pine.LNX.4.63.0701171446410.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 19 quoted lines

> On Wed, 17 Jan 2007, Josh Boyer wrote:
> 
> > Could we add an option to git-format-patch to use ".patch" as the file
> > suffix instead of ".txt"?  Something like the below?
> > 
> > diff --git a/builtin-log.c b/builtin-log.c
> > index a59b4ac..4eb2d32 100644
> > --- a/builtin-log.c
> > +++ b/builtin-log.c
> > @@ -217,6 +217,7 @@ static int git_format_config(const char *var,
> > const char *value)
> > 
> > static FILE *realstdout = NULL;
> > static const char *output_directory = NULL;
> > +static int psuffix = 0;
> 
> Why not
> 
> 	static const char *file_extension = ".txt"

Need to keep the length of that around for allocating string space and such. Is the flexibility worth the hassle?

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513