Re: [RFC] Add a suffix option to git-format-patch

From: Junio C Hamano <junkio@cox.net>
Date: Jan 17, 2007, 17:33 UTC
Message-ID: <7vejptsglj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87ps9d7j6t.fsf@morpheus.local>

David Kågedal <davidk@lysator.liu.se> writes:

Show 10 quoted lines

> "Josh Boyer" <jwboyer@gmail.com> writes:
>
>> I use git quite a bit to track my changes and then use
>> git-format-patch to generate patches to send on to others.  For the
>> most part, it works great but I find myself constantly doing:
>>
>> mv xxxx-foo.txt xxxx-foo.patch
>
> Seconded. I would even prefer .patch to be default, but I guess a
> config parameter would help me there.

Two minor objections to changing the default are: (1) it's a change and any change is bad ;-) and (2) the reason I changed it to .txt before submitting the original format-patch to Linus was because Emacs wanted to go into its "diff" mode when files are named with .patch suffix, which had two annoyances (read-only by default, and editing patch tried to automatically recount diff and its recounting screwed up in some cases I do not remember the details about).

I do not have a problem with a config or an option, though.