Re: [PATCH] Introduce 'git-format-patch --suffix=patch'
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 17, 2007, 19:27 UTC
- Message-ID
- <7vzm8hqws4.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <45AE7710.40503@shadowen.org>
Andy Whitcroft <apw@shadowen.org> writes:
Show 5 quoted lines
>> - strcpy(filename + len, ".txt"); >> + sprintf(filename + len, ".%s", fmt_patch_suffix); > > This doesn't give us any possibility of not having a suffix. Can we not > include the . in the suffix here so that we can specify it as "".
I've considered it, but I do not think it is worth it.
If we did so, the configuration would look like:
[format] suffix = .txt
which has a certain "Huh?" factor, and more importantly, a careless user would end up with a patchfile that is named:
0001-Introduce-git-format-patch-suffix-patchtxt
which is I think much worse than not being able to say:
0001-Introduce-git-format-patch-suffix-patch
But I do not care that much either way.