Re: [PATCH v3 2/2] help: cleanup the contruction of keys_uniq

From: Amisha Chhajed <amishhhaaaa@gmail.com>
Date: Feb 22, 2026, 09:47 UTC
Message-ID: <CAPvEtrfmgq8f2z7tAvR-oCEYoiG2B+Pj9EqjUsKuewnO73tVPg@mail.gmail.com>
In-Reply-To: <xmqqwm05qsei.fsf@gitster.g>

>
> The striking similarity of the body of the loops in these two
> functions bothered me enough to try writing this; the result does
> not look too bad, I think.

Agreed, I was also not very happy with the similarity present at these two places, especially the wildcard and tag part, tried to convulse them into something singular. It again started to look like the original so ultimately kept it like this.

Show 8 quoted lines

>
> By the way, I'd really prefer to see contributors *NOT* to use
> undeliverable and/or bouncing e-mail addresses when working on this
> project, as I'd always have to edit the Cc: list to avoid getting
> bounces.
>
> Thanks.
>

Thanks, I will take care.