Re: [PATCH v4 1/1] help: cleanup the contruction of keys_uniq

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 11, 2026, 21:39 UTC
Message-ID: <CAPig+cQ+HLjBjtGA9s_ZYYWNjRj_Bax5CkJFa98a-z=LoyEFoQ@mail.gmail.com>
In-Reply-To: <xmqqfr66m5qj.fsf@gitster.g>

On Wed, Mar 11, 2026 at 5:11 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> For example, in addition to the escape we see in t6030 above, the
> current pattern would not catch use of -E if it is written this way:
>
>         sed "-E" -e "
>                 ...
>         " human |
>         sort -u

Seems unlikely to arise in practice.

Show 7 quoted lines

> or
>
>         sed \
>                 -E -e "
>                 ...
>         " human |
>         sort -u

For what it's worth, line folding capability was added to check-non-portable-shell.pl by a0a630192d (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13), so it does correctly detect the errant -E in this example.

> and million other ways to subvert the simple-minded pattern-match
> based check.

True, for sure.