Re: [PATCH v4 1/1] help: cleanup the contruction of keys_uniq

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 11, 2026, 21:54 UTC
Message-ID: <CAPig+cS4vUDu0j5w3XvgdCXTV1bnwqeoGN3MRtmjvYsaMwsp6g@mail.gmail.com>
In-Reply-To: <xmqqwlzikpbz.fsf@gitster.g>

On Wed, Mar 11, 2026 at 5:51 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
>
> >>         sed \
> >>                 -E -e "
> >>                 ...
> >>         " human |
> >>         sort -u
> >
> > For what it's worth, line folding capability was added to
> > check-non-portable-shell.pl by a0a630192d (t/check-non-portable-shell:
> > detect "FOO=bar shell_func", 2018-07-13), so it does correctly detect
> > the errant -E in this example.
>
> Ah, thanks for correcting me.
>
> But "sed -n -i -e '/.../p'" would not catch "-i", and that is not
> all that unlikely, I suspect.

Correct. By only looking at the very first option following the command name (`sed`), the checking performed by check-non-portable-shell.pl is very weak indeed.