git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:25 UTC

Re: [PATCH v2 2/2] help: cleanup the contruction of keys_uniq

From
Amisha Chhajed <amishhhaaaa@gmail.com>
Date
Feb 21, 2026, 16:28 UTC
Message-ID
<CAPvEtrf37yJ2T2EsM3sgDodO=kdu_C5eXT9dmvcepzZwhAMzWQ@mail.gmail.com>
In-Reply-To
<xmqqecmpnu3g.fsf@gitster.g>
Show 32 quoted lines
>
> q> diff --git a/t/t0012-help.sh b/t/t0012-help.sh
> > index d3a0967e9d..0dbe6dd46f 100755
> > --- a/t/t0012-help.sh
> > +++ b/t/t0012-help.sh
> > @@ -160,6 +160,24 @@ test_expect_success 'git help --config-for-completion' '
> >       test_cmp human.munged vars
> >  '
> >
> > +test_expect_success 'git help --config-for-completion' '
> > +     file="$GIT_SOURCE_DIR/Documentation/config/add.adoc" &&
> > +     test_when_finished "git -C \"$GIT_SOURCE_DIR\" checkout -- Documentation/config/add.adoc" &&
> > +     cat <<-\EOF >>"$file" &&
> > +     aa*.b::
> > +     aa.b::
> > +     EOF
> > +     git help -c >human &&
> > +     grep -E \
> > +          -e "^[^.]+\.[^.]+$" \
> > +          -e "^[^.]+\.[^.]+\.[^.]+$" human |
> > +          sed -e "s/\*.*//" -e "s/<.*//" |
> > +          sort -u >human.munged &&
>
> Dedent "sed" and "sort" to the same level as "grep -E".
>
> > +     git help --config-for-completion >vars &&
> > +     test_cmp human.munged vars
> > +'
> > +
> >  test_expect_success 'git help --config-sections-for-completion' '
> >       git help -c >human &&
> >       grep -E \

had to drop this test, as it was working for a while locally on my machine because i had manually added the case in documentation then didn't make clean so the binary had it. Unfortunately i wasn't able to find a way that rebuilds config-list.h to test this, noticed that this topic is actively being worked on in https://lore.kernel.org/git/9cdcc9de04f0f8fff657f0474b31c063466ed808.1771280837.git.ben.knoble+github@gmail.com/T/#me826da3b6a128e1ceb7215d64328b7d6aa2b211e

Previous: Amisha ChhajedNext: Junio C Hamano
Message 15 of 31 in “clean leftover calls to string_list_remove_duplicates”
  1. 0/2 clean leftover calls to string_list_remove_duplicatesAmisha Chhajed, Feb 12, 2026
  2. 1/2 sparse-checkout: use string_list_sort_uAmisha Chhajed, Feb 12, 2026
  3. 2/2 help: ensure &keys_uniq follows sort -uAmisha Chhajed, Feb 12, 2026
  4. Junio C HamanoFeb 12, 2026
  5. Junio C HamanoFeb 12, 2026
  6. Amisha ChhajedFeb 12, 2026
  7. Junio C HamanoFeb 12, 2026
  8. 1/2 sparse-checkout: use string_list_sort_uAmisha Chhajed, Feb 13, 2026
  9. 2/2 help: cleanup the contruction of keys_uniqAmisha Chhajed, Feb 13, 2026
  10. Junio C HamanoFeb 13, 2026
  11. Eric SunshineFeb 13, 2026
  12. Junio C HamanoFeb 13, 2026
  13. 1/2 sparse-checkout: use string_list_sort_uAmisha Chhajed, Feb 21, 2026
  14. 2/2 help: cleanup the contruction of keys_uniqAmisha Chhajed, Feb 21, 2026
  15. Amisha ChhajedFeb 21, 2026
  16. Junio C HamanoFeb 22, 2026
  17. Junio C HamanoFeb 22, 2026
  18. Amisha ChhajedFeb 22, 2026
  19. Junio C HamanoFeb 26, 2026
  20. 0/1 Make keys_uniq stop depending on sort of keys_uniqAmisha Chhajed, Feb 28, 2026
  21. 1/1 help: cleanup the contruction of keys_uniqAmisha Chhajed, Feb 28, 2026
  22. Amisha ChhajedFeb 28, 2026
  23. Junio C HamanoMar 2, 2026
  24. Junio C HamanoMar 2, 2026
  25. help: cleanup the contruction of keys_uniqAmisha Chhajed, Mar 11, 2026
  26. Junio C HamanoMar 11, 2026
  27. Amisha ChhajedMar 11, 2026
  28. Junio C HamanoMar 11, 2026
  29. Eric SunshineMar 11, 2026
  30. Junio C HamanoMar 11, 2026
  31. Eric SunshineMar 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.