Re: [PATCH v2 2/2] help: cleanup the contruction of keys_uniq
- From
Amisha Chhajed <amishhhaaaa@gmail.com>
- Date
- Feb 21, 2026, 16:28 UTC
- Message-ID
- <CAPvEtrf37yJ2T2EsM3sgDodO=kdu_C5eXT9dmvcepzZwhAMzWQ@mail.gmail.com>
- In-Reply-To
- <xmqqecmpnu3g.fsf@gitster.g>
Show 32 quoted lines
> > q> diff --git a/t/t0012-help.sh b/t/t0012-help.sh > > index d3a0967e9d..0dbe6dd46f 100755 > > --- a/t/t0012-help.sh > > +++ b/t/t0012-help.sh > > @@ -160,6 +160,24 @@ test_expect_success 'git help --config-for-completion' ' > > test_cmp human.munged vars > > ' > > > > +test_expect_success 'git help --config-for-completion' ' > > + file="$GIT_SOURCE_DIR/Documentation/config/add.adoc" && > > + test_when_finished "git -C \"$GIT_SOURCE_DIR\" checkout -- Documentation/config/add.adoc" && > > + cat <<-\EOF >>"$file" && > > + aa*.b:: > > + aa.b:: > > + EOF > > + git help -c >human && > > + grep -E \ > > + -e "^[^.]+\.[^.]+$" \ > > + -e "^[^.]+\.[^.]+\.[^.]+$" human | > > + sed -e "s/\*.*//" -e "s/<.*//" | > > + sort -u >human.munged && > > Dedent "sed" and "sort" to the same level as "grep -E". > > > + git help --config-for-completion >vars && > > + test_cmp human.munged vars > > +' > > + > > test_expect_success 'git help --config-sections-for-completion' ' > > git help -c >human && > > grep -E \
had to drop this test, as it was working for a while locally on my machine because i had manually added the case in documentation then didn't make clean so the binary had it. Unfortunately i wasn't able to find a way that rebuilds config-list.h to test this, noticed that this topic is actively being worked on in https://lore.kernel.org/git/9cdcc9de04f0f8fff657f0474b31c063466ed808.1771280837.git.ben.knoble+github@gmail.com/T/#me826da3b6a128e1ceb7215d64328b7d6aa2b211e