git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:26 UTC

Re: [PATCH v3 2/2] help: cleanup the contruction of keys_uniq

From
Amisha Chhajed <amishhhaaaa@gmail.com>
Date
Feb 28, 2026, 10:51 UTC
Message-ID
<CAPvEtrf_m1Uae27Z9ZKsSJsu=_HAeT8fMO80cnVGc4dfVtrTBQ@mail.gmail.com>
In-Reply-To
<xmqqjyvz4foj.fsf@gitster.g>
Incredibly sorry for the bouncing mail once again, I will fix it locally.
On Thu, 26 Feb 2026 at 22:15, Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
>
> Amisha Chhajed <amishhhaaaa@gmail.com> writes:
>
> >>
> >> The striking similarity of the body of the loops in these two
> >> functions bothered me enough to try writing this; the result does
> >> not look too bad, I think.
> >
> >
> > Agreed, I was also not very happy with the similarity present at these
> > two places,
> > especially the wildcard and tag part, tried to convulse them into something
> > singular. It again started to look like the original so ultimately
> > kept it like this.
> >
> >>
> >> By the way, I'd really prefer to see contributors *NOT* to use
> >> undeliverable and/or bouncing e-mail addresses when working on this
> >> project, as I'd always have to edit the Cc: list to avoid getting
> >> bounces.
> >>
> >> Thanks.
> >>
> >
> > Thanks, I will take care.
>
> Thanks.
-- 
Thanks,
Amisha
Previous: Amisha ChhajedNext: Junio C Hamano
Message 22 of 31 in “clean leftover calls to string_list_remove_duplicates”
  1. 0/2 clean leftover calls to string_list_remove_duplicatesAmisha Chhajed, Feb 12, 2026
  2. 1/2 sparse-checkout: use string_list_sort_uAmisha Chhajed, Feb 12, 2026
  3. 2/2 help: ensure &keys_uniq follows sort -uAmisha Chhajed, Feb 12, 2026
  4. Junio C HamanoFeb 12, 2026
  5. Junio C HamanoFeb 12, 2026
  6. Amisha ChhajedFeb 12, 2026
  7. Junio C HamanoFeb 12, 2026
  8. 1/2 sparse-checkout: use string_list_sort_uAmisha Chhajed, Feb 13, 2026
  9. 2/2 help: cleanup the contruction of keys_uniqAmisha Chhajed, Feb 13, 2026
  10. Junio C HamanoFeb 13, 2026
  11. Eric SunshineFeb 13, 2026
  12. Junio C HamanoFeb 13, 2026
  13. 1/2 sparse-checkout: use string_list_sort_uAmisha Chhajed, Feb 21, 2026
  14. 2/2 help: cleanup the contruction of keys_uniqAmisha Chhajed, Feb 21, 2026
  15. Amisha ChhajedFeb 21, 2026
  16. Junio C HamanoFeb 22, 2026
  17. Junio C HamanoFeb 22, 2026
  18. Amisha ChhajedFeb 22, 2026
  19. Junio C HamanoFeb 26, 2026
  20. 0/1 Make keys_uniq stop depending on sort of keys_uniqAmisha Chhajed, Feb 28, 2026
  21. 1/1 help: cleanup the contruction of keys_uniqAmisha Chhajed, Feb 28, 2026
  22. Amisha ChhajedFeb 28, 2026
  23. Junio C HamanoMar 2, 2026
  24. Junio C HamanoMar 2, 2026
  25. help: cleanup the contruction of keys_uniqAmisha Chhajed, Mar 11, 2026
  26. Junio C HamanoMar 11, 2026
  27. Amisha ChhajedMar 11, 2026
  28. Junio C HamanoMar 11, 2026
  29. Eric SunshineMar 11, 2026
  30. Junio C HamanoMar 11, 2026
  31. Eric SunshineMar 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.