[PATCH 0/2] clean leftover calls to string_list_remove_duplicates
- From
Amisha Chhajed <amishhhaaaa@gmail.com>
- Date
- Feb 12, 2026, 04:10 UTC
- Message-ID
- <20260212041017.91370-1-amishhhaaaa@gmail.com>
replace calls to string_list_remove_duplicates with string_list_sort_u.
sorted behavior of &keys_uniq depends on the call to string_list_sort on &keys before &keys is processed to form &keys_uniq, this introduces an edge case where &keys_uniq will not be sorted as expected, follow [1] to reproduce. add string_list_sort_u to &keys_uniq to fix this edge case and ensure future enhancements to the processing logic does not introduce regressions.
[1] run command: cat <<'EOF' >> Documentation/config/add.adoc aa*.b:: aa.b:: EOF from git/ and then make test, this sees one failure when the test compared actual output with sort -u output.
Amisha Chhajed (2): sparse-checkout: use string_list_sort_u help: ensure &keys_uniq follows sort -u
builtin/help.c | 2 +- builtin/sparse-checkout.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
-- 2.52.0