git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/6] Move PGP verification out of verify-tag

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 18, 2016, 18:14 UTC
Message-ID
<CAPig+cSmb9wFCV+9PS4LYfd3hAH5s6ifRk8orVv+e2Q=h7F3Ag@mail.gmail.com>
In-Reply-To
<1460932021-27633-1-git-send-email-santiago@nyu.edu>
On Sun, Apr 17, 2016 at 6:26 PM,  <santiago@nyu.edu> wrote:
Show 10 quoted lines
> This is a follow up of [1], [2], [3], [4], and [5]. patches 1/6, 2/6 and 3/6
> are the same as the corresponding commits in pu.
>
> v6:
>  * As Junio suggested, updated 4/6, to include the name argument and the
>    ternary operator to provide more descriptive error messages. I propagated
>    these changes to 5/6 and 6/6 as well. I'm unsure about the 80-column
>    on 4/6, the ternary operator is rather long.
>  * Updated and reviewed the commit messages based on Eric and Junio's
>    feedback

Thanks. See my responses to individual patches for a few very minor issues, not necessarily even deserving a re-roll. With or without the code and commit message nits addressed, this version is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Previous: Eric SunshineNext: Junio C Hamano
Message 13 of 15 in “Move PGP verification out of verify-tag”
  1. 0/6 Move PGP verification out of verify-tagsantiago@nyu.edu, Apr 17, 2016
  2. 1/6 builtin/verify-tag.c: ignore SIGPIPE in gpg-interfacesantiago@nyu.edu, Apr 17, 2016
  3. 2/6 t7030: test verifying multiple tagssantiago@nyu.edu, Apr 17, 2016
  4. 3/6 verify-tag: change variable name for readabilitysantiago@nyu.edu, Apr 17, 2016
  5. Eric SunshineApr 18, 2016
  6. Jeff KingApr 19, 2016
  7. 4/6 verify-tag: add sha1 argument to verify_tag()santiago@nyu.edu, Apr 17, 2016
  8. Eric SunshineApr 18, 2016
  9. Junio C HamanoApr 18, 2016
  10. 5/6 verify-tag: move verification code to tag.csantiago@nyu.edu, Apr 17, 2016
  11. 6/6 tag -v: verfy directly rather than exec-ing verify-tagsantiago@nyu.edu, Apr 17, 2016
  12. Eric SunshineApr 18, 2016
  13. Eric SunshineApr 18, 2016
  14. Junio C HamanoApr 18, 2016
  15. Jeff KingApr 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.