git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 3/6] verify-tag: change variable name for readability

From
santiago@nyu.edu <santiago@nyu.edu>
Date
Apr 17, 2016, 22:26 UTC
Message-ID
<1460932021-27633-4-git-send-email-santiago@nyu.edu>
In-Reply-To
<1460932021-27633-1-git-send-email-santiago@nyu.edu>
From: Santiago Torres <santiago@nyu.edu>
The run_gpg_verify() function has two variables, size and len.

This may come off as confusing when reading the code. Clarify which one pertains to the length of the tag headers by renaming len to payload_length.

Signed-off-by: Santiago Torres <santiago@nyu.edu>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/verify-tag.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c
index 77f070a..010353c 100644
--- a/builtin/verify-tag.c
+++ b/builtin/verify-tag.c
@@ -21,20 +21,21 @@ static const char * const verify_tag_usage[] = {
 static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
 {
 	struct signature_check sigc;
-	int len;
+	int payload_size;
 	int ret;
 
 	memset(&sigc, 0, sizeof(sigc));
 
-	len = parse_signature(buf, size);
+	payload_size = parse_signature(buf, size);
 
-	if (size == len) {
+	if (size == payload_size) {
 		if (flags & GPG_VERIFY_VERBOSE)
-			write_in_full(1, buf, len);
+			write_in_full(1, buf, payload_size);
 		return error("no signature found");
 	}
 
-	ret = check_signature(buf, len, buf + len, size - len, &sigc);
+	ret = check_signature(buf, payload_size, buf + payload_size,
+				size - payload_size, &sigc);
 	print_signature_buffer(&sigc, flags);
 
 	signature_check_clear(&sigc);
-- 
2.8.0
Previous: santiago@nyu.eduNext: Eric Sunshine
Message 4 of 15 in “Move PGP verification out of verify-tag”
  1. 0/6 Move PGP verification out of verify-tagsantiago@nyu.edu, Apr 17, 2016
  2. 1/6 builtin/verify-tag.c: ignore SIGPIPE in gpg-interfacesantiago@nyu.edu, Apr 17, 2016
  3. 2/6 t7030: test verifying multiple tagssantiago@nyu.edu, Apr 17, 2016
  4. 3/6 verify-tag: change variable name for readabilitysantiago@nyu.edu, Apr 17, 2016
  5. Eric SunshineApr 18, 2016
  6. Jeff KingApr 19, 2016
  7. 4/6 verify-tag: add sha1 argument to verify_tag()santiago@nyu.edu, Apr 17, 2016
  8. Eric SunshineApr 18, 2016
  9. Junio C HamanoApr 18, 2016
  10. 5/6 verify-tag: move verification code to tag.csantiago@nyu.edu, Apr 17, 2016
  11. 6/6 tag -v: verfy directly rather than exec-ing verify-tagsantiago@nyu.edu, Apr 17, 2016
  12. Eric SunshineApr 18, 2016
  13. Eric SunshineApr 18, 2016
  14. Junio C HamanoApr 18, 2016
  15. Jeff KingApr 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.