Re: [PATCH v6 0/6] Move PGP verification out of verify-tag

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 18, 2016, 20:15 UTC
Message-ID: <xmqqshyi4qsj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1460932021-27633-1-git-send-email-santiago@nyu.edu>

santiago@nyu.edu writes:

>    I'm unsure about the 80-column
>    on 4/6, the ternary operator is rather long.

You can do something like this:

        type = sha1_object_info(sha1, NULL);
        if (type != OBJ_TAG)
                return error("%s: cannot verify a non-tag object of type %s.",
                             report_name ?
                             report_name :
                             find_unique_abbrev(sha1, DEFAULT_ABBREV),
                             typename(type));

        buf = read_sha1_file(sha1, &type, &size);
        if (!buf)
                return error("%s: unable to read file.",
                             report_name ?
                             report_name :
                             find_unique_abbrev(sha1, DEFAULT_ABBREV));

Thanks.