Re: [PATCH v6 6/6] tag -v: verfy directly rather than exec-ing verify-tag

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 18, 2016, 18:00 UTC
Message-ID: <CAPig+cTWit2NcVBV+r4o0ztOQx7=4XjNKbeo=HA7EAxasw6HsA@mail.gmail.com>
In-Reply-To: <1460932021-27633-7-git-send-email-santiago@nyu.edu>

On Sun, Apr 17, 2016 at 6:27 PM,  <santiago@nyu.edu> wrote:

> tag -v forks into verify-tag, which only calls gpg_verify_tag().

"forks into" sounds odd.

> Instead of forking to verify-tag, call gpg_verify_tag directly().

s/ directly()/() directly/

I found the commit message of your previous version[1] more descriptive and easier to understand (minus the grammo):

    Instead of running the verify-tag plumbing command, use the
    gpg_verify_tag() function to avoid doing an additional fork call.

The patch itself looks fine.

[1]: http://article.gmane.org/gmane.comp.version-control.git/290831

Show 22 quoted lines

> Signed-off-by: Santiago Torres <santiago@nyu.edu>
> ---
> diff --git a/builtin/tag.c b/builtin/tag.c
> index 1705c94..7b2918e 100644
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -104,13 +104,7 @@ static int delete_tag(const char *name, const char *ref,
>  static int verify_tag(const char *name, const char *ref,
>                                 const unsigned char *sha1)
>  {
> -       const char *argv_verify_tag[] = {"verify-tag",
> -                                       "-v", "SHA1_HEX", NULL};
> -       argv_verify_tag[2] = sha1_to_hex(sha1);
> -
> -       if (run_command_v_opt(argv_verify_tag, RUN_GIT_CMD))
> -               return error(_("could not verify the tag '%s'"), name);
> -       return 0;
> +       return gpg_verify_tag(sha1, name, GPG_VERIFY_VERBOSE);
>  }
>
>  static int do_sign(struct strbuf *buffer)
> --