From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 18 Apr 2016 18:14:26 GMT
Subject: Re: [PATCH v6 0/6] Move PGP verification out of verify-tag
Message-ID: <CAPig+cSmb9wFCV+9PS4LYfd3hAH5s6ifRk8orVv+e2Q=h7F3Ag@mail.gmail.com>
In-Reply-To: <1460932021-27633-1-git-send-email-santiago@nyu.edu>

On Sun, Apr 17, 2016 at 6:26 PM,  <santiago@nyu.edu> wrote:
> This is a follow up of [1], [2], [3], [4], and [5]. patches 1/6, 2/6 and 3/6
> are the same as the corresponding commits in pu.
>
> v6:
>  * As Junio suggested, updated 4/6, to include the name argument and the
>    ternary operator to provide more descriptive error messages. I propagated
>    these changes to 5/6 and 6/6 as well. I'm unsure about the 80-column
>    on 4/6, the ternary operator is rather long.
>  * Updated and reviewed the commit messages based on Eric and Junio's
>    feedback

Thanks. See my responses to individual patches for a few very minor
issues, not necessarily even deserving a re-roll. With or without the
code and commit message nits addressed, this version is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>