git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] shallow: extract a header file for shallow-related functions

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 29, 2020, 22:48 UTC
Message-ID
<CAPig+cS4K=crmPqdb0xeoD0H9FGCYdxb4GhQLCoRPEs-uurz6g@mail.gmail.com>
In-Reply-To
<0b93abe072aa35ab96ba3b97118caa8ffe8e439d.1588199705.git.me@ttaylorr.com>
On Wed, Apr 29, 2020 at 6:39 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 9 quoted lines
> There are many functions in commit.h that are more related to shallow
> repositories than they are to any sort of generic commit machinery.
> Likely this began when there were only a few shallow-related functions,
> and commit.h seemed a reasonable enough place to put them.
>
> But, now there are a good number of shallow-related functions, and
> placing them all in 'commit.h' doesn't make sense.
>
> This patch extracts a 'shallow.h', which takes all of the headers from
Did you mean s/headers/declarations/ ?
Show 8 quoted lines
> 'commit.h' for functions which already exist in 'shallow.c'. We will
> bring the remaining shallow-related functions defined in 'commit.c' in a
> subsequent patch.
>
> For now, move only the ones that already are implemented in 'shallow.c',
> and update the necessary includes.
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
Previous: Taylor BlauNext: Jonathan Tan
Message 6 of 22 in “shallow: extract a header file”
  1. 0/5 shallow: extract a header fileTaylor Blau, Apr 29, 2020
  2. 1/5 commit: make 'commit_graft_pos' non-staticTaylor Blau, Apr 29, 2020
  3. Jonathan NiederApr 30, 2020
  4. Taylor BlauApr 30, 2020
  5. 2/5 shallow: extract a header file for shallow-related functionsTaylor Blau, Apr 29, 2020
  6. Eric SunshineApr 29, 2020
  7. Jonathan TanApr 30, 2020
  8. Taylor BlauApr 30, 2020
  9. Jonathan TanApr 30, 2020
  10. Jonathan NiederApr 30, 2020
  11. 3/5 commit: move 'unregister_shallow' to 'shallow.h'Taylor Blau, Apr 29, 2020
  12. Jonathan NiederApr 30, 2020
  13. Taylor BlauApr 30, 2020
  14. 4/5 shallow.h: document '{commit,rollback}_shallow_file'Taylor Blau, Apr 29, 2020
  15. Eric SunshineApr 29, 2020
  16. 5/5 shallow: use struct 'shallow_lock' for additional safetyTaylor Blau, Apr 29, 2020
  17. Eric SunshineApr 29, 2020
  18. Taylor BlauApr 29, 2020
  19. Jonathan TanApr 30, 2020
  20. Jonathan NiederApr 30, 2020
  21. Eric SunshineApr 30, 2020
  22. Taylor BlauApr 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.