git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] shallow: extract a header file for shallow-related functions

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Apr 30, 2020, 18:23 UTC
Message-ID
<20200430182302.1969-1-jonathantanmy@google.com>
In-Reply-To
<20200430005945.GA23090@syl.local>
Show 7 quoted lines
> Yes, I should have mentioned in the cover letter that this is based on
> 'tb/reset-shallow' which is should be part of Junio's next push to
> master. I didn't mention it because I figured that it would be on master
> by the time anyone wanted to look at these patches ;).
> 
> Anyhow, apologies. It should apply cleanly on any branch that has
> 'tb/reset-shallow' already.

Thanks. Now that I'm able to apply the patches, I see that the prototype for unregister_shallow() was removed with no corresponding addition. This causes a compile error when running "make" with DEVELOPER=1. Other than that, things look fine.

Previous: Taylor BlauNext: Jonathan Nieder
Message 9 of 22 in “shallow: extract a header file”
  1. 0/5 shallow: extract a header fileTaylor Blau, Apr 29, 2020
  2. 1/5 commit: make 'commit_graft_pos' non-staticTaylor Blau, Apr 29, 2020
  3. Jonathan NiederApr 30, 2020
  4. Taylor BlauApr 30, 2020
  5. 2/5 shallow: extract a header file for shallow-related functionsTaylor Blau, Apr 29, 2020
  6. Eric SunshineApr 29, 2020
  7. Jonathan TanApr 30, 2020
  8. Taylor BlauApr 30, 2020
  9. Jonathan TanApr 30, 2020
  10. Jonathan NiederApr 30, 2020
  11. 3/5 commit: move 'unregister_shallow' to 'shallow.h'Taylor Blau, Apr 29, 2020
  12. Jonathan NiederApr 30, 2020
  13. Taylor BlauApr 30, 2020
  14. 4/5 shallow.h: document '{commit,rollback}_shallow_file'Taylor Blau, Apr 29, 2020
  15. Eric SunshineApr 29, 2020
  16. 5/5 shallow: use struct 'shallow_lock' for additional safetyTaylor Blau, Apr 29, 2020
  17. Eric SunshineApr 29, 2020
  18. Taylor BlauApr 29, 2020
  19. Jonathan TanApr 30, 2020
  20. Jonathan NiederApr 30, 2020
  21. Eric SunshineApr 30, 2020
  22. Taylor BlauApr 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.