Re: [PATCH 3/5] commit: move 'unregister_shallow' to 'shallow.h'

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 30, 2020, 03:13 UTC
Message-ID: <20200430031350.GD115238@google.com>
In-Reply-To: <65ecfeaba56807926fbe532f94921c98298e50d5.1588199705.git.me@ttaylorr.com>

Taylor Blau wrote:

Show 10 quoted lines

> In the last commit, we introduced a header for the functions defined in
> 'shallow.c'. There is one remaining shallow-related function in
> commit.c which should be moved, too. This patch moves that function.
> 
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
>  commit.c  | 13 -------------
>  shallow.c | 13 +++++++++++++
>  shallow.h |  1 +
>  3 files changed, 14 insertions(+), 13 deletions(-)

Yes, an obviously good thing to do.

Perhaps could be squashed with patch 1 (but also see my review of that one).

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Should this take a "struct repository" parameter?